Issue 305513003: Add ppapi, improve Windows GN build.

Issue 305513003: Add ppapi, improve Windows GN build. (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
scottmg

CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, dmikurube+memory_chromium.org, piman+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add ppapi, improve Windows GN build. This adds ppapi-related targets except the tests to the GN build. Did some minor tweaks to the .gypi ppapi lists. Some files were duplicated between the trusted and common lists which causes errors in GN (it doesn't uniquify the lists like GYP). Common is used in every place trusted is, so I just removed the duplicates from the trusted list. Fixed some warnings in skia and tcmalloc. Added the ability to undefine NOMINMAX on Windows. Fixed some src/ui Windows compilation issues. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273016

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : comments fixed #

Patch Set 4 : #

Patch Set 5 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+784 lines, -26 lines)			Patch
M	BUILD.gn	View	1 2 3 4	2 chunks	+2 lines, -0 lines	0 comments	Download
M	base/allocator/BUILD.gn	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	build/config/BUILDCONFIG.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	build/config/win/BUILD.gn	View		2 chunks	+12 lines, -1 line	0 comments	Download
M	content/common/BUILD.gn	View		1 chunk	+0 lines, -3 lines	0 comments	Download
A +	gpu/ipc/BUILD.gn	View	1 2	1 chunk	+6 lines, -6 lines	0 comments	Download
A	ppapi/BUILD.gn	View	1 2 3	1 chunk	+725 lines, -0 lines	0 comments	Download
M	ppapi/ppapi_sources.gypi	View	1 2	2 chunks	+0 lines, -4 lines	0 comments	Download
M	skia/BUILD.gn	View	1 2	2 chunks	+15 lines, -0 lines	0 comments	Download
M	ui/base/BUILD.gn	View		4 chunks	+17 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/305513003/diff/20001/gpu/ipc/BUILD.gn File gpu/ipc/BUILD.gn (right): https://codereview.chromium.org/305513003/diff/20001/gpu/ipc/BUILD.gn#newcode7 gpu/ipc/BUILD.gn:7: "ipc/gpu_command_buffer_traits.cc", extra ipc/ here https://codereview.chromium.org/305513003/diff/20001/skia/BUILD.gn File skia/BUILD.gn (right): ...

6 years, 7 months ago (2014-05-26 19:00:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #5 manually as r273016.

Expand Messages | Collapse Messages