Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 305503002: Emit partial results if binary_size is interrupted. (Closed)

Created:
6 years, 7 months ago by Daniel Bratell
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Emit partial results if binary_size is interrupted. Instead of just throwing away everything if the user presses Ctrl-c, write down whatever data we have to the disk. By asking for the largest symbols first, it's sometimes possible to get a quite good picture after only 10-15% of the total runtime. BUG=377466 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275053

Patch Set 1 #

Total comments: 2

Patch Set 2 : Partial output: Addressed review issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -31 lines) Patch
M tools/binary_size/run_binary_size_analysis.py View 1 4 chunks +46 lines, -31 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Daniel Bratell
6 years, 7 months ago (2014-05-26 13:56:05 UTC) #1
Daniel Bratell
6 years, 7 months ago (2014-05-26 13:56:45 UTC) #2
Primiano Tucci (use gerrit)
LGTM % 2 nits. https://codereview.chromium.org/305503002/diff/1/tools/binary_size/run_binary_size_analysis.py File tools/binary_size/run_binary_size_analysis.py (right): https://codereview.chromium.org/305503002/diff/1/tools/binary_size/run_binary_size_analysis.py#newcode483 tools/binary_size/run_binary_size_analysis.py:483: print('Interrupting - killing subprocesses.') Can ...
6 years, 7 months ago (2014-05-27 09:31:46 UTC) #3
Andrew Hayden (chromium.org)
LGTM % primiano
6 years, 7 months ago (2014-05-27 10:38:32 UTC) #4
Primiano Tucci (use gerrit)
On 2014/05/27 10:38:32, Andrew Hayden wrote: > LGTM % primiano Does it mean that the ...
6 years, 7 months ago (2014-05-27 11:54:34 UTC) #5
Daniel Bratell
On 2014/05/27 09:31:46, Primiano Tucci wrote: > LGTM % 2 nits. > > https://codereview.chromium.org/305503002/diff/1/tools/binary_size/run_binary_size_analysis.py > ...
6 years, 6 months ago (2014-06-04 13:35:29 UTC) #6
Daniel Bratell
The CQ bit was checked by bratell@opera.com
6 years, 6 months ago (2014-06-05 07:15:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/305503002/20001
6 years, 6 months ago (2014-06-05 07:17:34 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 09:16:49 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 09:37:21 UTC) #10
Message was sent while issue was closed.
Change committed as 275053

Powered by Google App Engine
This is Rietveld 408576698