Issue 3055001: Use different separators for service-type and service-name in Kerberos SPN.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3055001: Use different separators for service-type and service-name in Kerberos SPN. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by cbentzel

Modified:
4 years ago

Reviewers:
ahendrickson

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Use different separators for service-type and service-name in Kerberos SPN. GSSAPI expects SPNs to be in the form HTTP@<server_name> and SSPI expects SPNs to be in the form HTTP/<server_name>. BUG=33033 TEST=net_unittests --gtest_filter="*HttpAuthHandlerNegotiate*", go against Kerberized server on Linux or OSX and see that the TGS is retrieved correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52984

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -3 lines)			Patch
	M	net/http/http_auth_handler_negotiate.cc	View		2 chunks	+10 lines, -3 lines	0 comments	Download
	M	net/http/http_auth_handler_negotiate_unittest.cc	View		5 chunks	+20 lines, -0 lines	0 comments	Download

Trybot results: linux mac win

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

On 2010/07/19 19:55:23, cbentzel wrote:
>

Expand Messages | Collapse Messages