Issue 305493003: Reland "Customized support for feedback on calls to Array." and follow-up fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305493003: Reland "Customized support for feedback on calls to Array." and follow-up fixes. (Closed)

Created:
6 years, 7 months ago by mvstanton

Modified:
6 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Reland "Customized support for feedback on calls to Array." and follow-up fixes. Comparing one CallIC::State to another was not done correctly, leading to a failure to patch a CallIC when transitioning from monomorphic Array to megamorphic. BUG=chromium:377198, chromium:377290 LOG=Y R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21499

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+726 lines, -256 lines)			Patch
M	src/arm/code-stubs-arm.cc	View		6 chunks	+65 lines, -9 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.cc	View		6 chunks	+73 lines, -11 lines	0 comments	Download
M	src/ast.h	View		2 chunks	+15 lines, -0 lines	0 comments	Download
M	src/code-stubs.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/hydrogen.h	View		3 chunks	+16 lines, -2 lines	0 comments	Download
M	src/hydrogen.cc	View		9 chunks	+83 lines, -66 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		5 chunks	+68 lines, -11 lines	0 comments	Download
M	src/ic.h	View	1	5 chunks	+34 lines, -8 lines	0 comments	Download
M	src/ic.cc	View	1	3 chunks	+62 lines, -6 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View		7 chunks	+66 lines, -10 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+23 lines, -6 lines	0 comments	Download
M	src/type-info.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/type-info.cc	View		3 chunks	+14 lines, -4 lines	0 comments	Download
M	src/typing.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View		5 chunks	+67 lines, -8 lines	0 comments	Download
M	test/mjsunit/array-constructor-feedback.js	View		4 chunks	+9 lines, -23 lines	0 comments	Download
M	test/mjsunit/array-feedback.js	View	1	2 chunks	+108 lines, -92 lines	0 comments	Download
A	test/mjsunit/regress/regress-377290.js	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

mvstanton

Hi Jakob, thanks for the help on this issue. Here is the fix we discussed. ...

6 years, 7 months ago (2014-05-26 12:57:38 UTC) #1

Jakob Kummerow

LGTM. I've changed the CL description for you to mention the other bug too.

6 years, 7 months ago (2014-05-26 13:36:35 UTC) #2

mvstanton

6 years, 7 months ago (2014-05-26 13:59:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21499 (presubmit successful).