Issue 305473005: Check browser's exit code in BrowserTestBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305473005: Check browser's exit code in BrowserTestBase (Closed)

Created:
6 years, 7 months ago by Paweł Hajdan Jr.

Modified:
6 years, 6 months ago

Reviewers:
jam, jabdelmalek, jochen (gone - plz use gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
M	chrome/browser/first_run/try_chrome_dialog_view_browsertest.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	content/public/test/browser_test_base.h	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	content/public/test/browser_test_base.cc	View	1	3 chunks	+5 lines, -2 lines	0 comments	Download

Total messages: 7 (0 generated)

Paweł Hajdan Jr.

Could you take another look? I had to make some changes to pass trybots, and ...

6 years, 6 months ago (2014-05-29 10:20:11 UTC) #3

Alexander Potapenko

On 2014/05/29 10:20:11, Paweł Hajdan Jr. wrote: > Could you take another look? > > ...

6 years, 6 months ago (2014-06-03 14:01:52 UTC) #4

Paweł Hajdan Jr.

6 years, 6 months ago (2014-06-05 14:27:13 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as r275096 (presubmit successful).