Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 305473005: Check browser's exit code in BrowserTestBase (Closed)

Created:
6 years, 7 months ago by Paweł Hajdan Jr.
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/browser/first_run/try_chrome_dialog_view_browsertest.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M content/public/test/browser_test_base.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/public/test/browser_test_base.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Paweł Hajdan Jr.
6 years, 7 months ago (2014-05-27 16:17:28 UTC) #1
jam
lgtm
6 years, 7 months ago (2014-05-27 17:57:08 UTC) #2
Paweł Hajdan Jr.
Could you take another look? I had to make some changes to pass trybots, and ...
6 years, 6 months ago (2014-05-29 10:20:11 UTC) #3
Alexander Potapenko
On 2014/05/29 10:20:11, Paweł Hajdan Jr. wrote: > Could you take another look? > > ...
6 years, 6 months ago (2014-06-03 14:01:52 UTC) #4
Paweł Hajdan Jr.
6 years, 6 months ago (2014-06-03 15:54:53 UTC) #5
jabdelmalek
lgtm
6 years, 6 months ago (2014-06-03 17:22:56 UTC) #6
Paweł Hajdan Jr.
6 years, 6 months ago (2014-06-05 14:27:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r275096 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698