Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5312)

Unified Diff: chrome/browser/history/chrome_history_client.h

Issue 305443004: Introduce HistoryClient interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@371825
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/chrome_history_client.h
diff --git a/chrome/browser/history/chrome_history_client.h b/chrome/browser/history/chrome_history_client.h
new file mode 100644
index 0000000000000000000000000000000000000000..f8712f91e9dcfea7c41bf4afaab9138ee52124ae
--- /dev/null
+++ b/chrome/browser/history/chrome_history_client.h
@@ -0,0 +1,38 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_H_
+#define CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_H_
+
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "components/history/core/browser/history_client.h"
+#include "components/keyed_service/core/keyed_service.h"
+
+class Profile;
+class HistoryService;
+
+namespace history {
+
+class ChromeHistoryClient : public HistoryClient,
blundell 2014/05/27 09:56:38 should have a class comment.
sdefresne 2014/05/28 17:10:42 Done.
+ public KeyedService {
+ public:
+ explicit ChromeHistoryClient(Profile* profile);
+
+ HistoryService* history_service() const {
blundell 2014/05/27 09:56:38 const methods should return const pointers (or it
sdefresne 2014/05/28 17:10:42 Done.
+ return history_service_.get();
+ }
+
+ // KeyedService:
+ virtual void Shutdown() OVERRIDE;
+
+ private:
+ scoped_ptr<HistoryService> history_service_;
+
+ DISALLOW_COPY_AND_ASSIGN(ChromeHistoryClient);
+};
+
+} // namespace history
+
+#endif // CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_H_

Powered by Google App Engine
This is Rietveld 408576698