Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 305423003: Reland: Enable touch text selection by default on desktop Aura (Closed)

Created:
6 years, 6 months ago by mohsen
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Reland: Enable touch text selection by default on desktop Aura --disable-touch-editing can be used to disable touch text selection. Originally landed as r274972, but reverted due to blink layout test failures. Layout tests are fixed in r175595 (blink). BUG=304872 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274972 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275452

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ui_base_switches_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
mohsen
Please take a look
6 years, 6 months ago (2014-06-04 21:30:48 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-04 23:22:39 UTC) #2
mohsen
The CQ bit was checked by mohsen@chromium.org
6 years, 6 months ago (2014-06-04 23:41:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/305423003/1
6 years, 6 months ago (2014-06-04 23:43:27 UTC) #4
commit-bot: I haz the power
Change committed as 274972
6 years, 6 months ago (2014-06-05 01:11:09 UTC) #5
Peter Beverloo
A revert of this CL has been created in https://codereview.chromium.org/313263004/ by peter@chromium.org. The reason for ...
6 years, 6 months ago (2014-06-05 13:48:47 UTC) #6
mohsen
The CQ bit was checked by mohsen@chromium.org
6 years, 6 months ago (2014-06-06 15:59:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/305423003/1
6 years, 6 months ago (2014-06-06 16:00:36 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 16:02:05 UTC) #9
Message was sent while issue was closed.
Change committed as 275452

Powered by Google App Engine
This is Rietveld 408576698