Limited number of buildsets that can be used to initialize RietveldPollerWithCache's cache

scripts/master/unittests/try_job_rietveld_test.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """try_job_rietveld.py testcases."""
 
 import test_env
 from common import find_depot_tools
 
@@ skipping 19 matching lines @@
   [{'timestamp': datetime.datetime.utcnow(), 'key': 'test_key_1'}],
   [{'timestamp': (datetime.datetime.utcnow() -
                   datetime.timedelta(hours=5, minutes=59)),
     'key': 'test_key_2'},
    {'timestamp': (datetime.datetime.utcnow() -
                   datetime.timedelta(hours=6, minutes=1)),
     'key': 'test_key_3'}]
 ]
 
 
-class MockBuildRequestsDB(object):
-
-  def __init__(self):
-    self._build_requests = []
-
-  def addBuildRequest(self, build_request):
-    self._build_requests.append(build_request)
-
-  def getBuildRequests(self):
-    return self._build_requests
-
-
 class MockBuildSetsDB(object):
 
     def __init__(self):
       self._buildset_props = {}
 
     def addBuildSetProperties(self, bsid, buildset_props):
       self._buildset_props[bsid] = buildset_props
 
     def getBuildsetProperties(self, bsid):
       return self._buildset_props[bsid]
 
+    def getRecentBuildsets(self, count):
+      return [{'bsid': bsid} for bsid in self._buildset_props.keys()][:count]
+
 
 class MockDBCollection(object):
 
-    buildrequests = None
     buildsets = None
 
     def __init__(self):
-      self.buildrequests = MockBuildRequestsDB()
       self.buildsets = MockBuildSetsDB()
 
 
 class MockMaster(object):
 
   db = None
 
   def __init__(self):
     self.db = MockDBCollection()
 
@@ skipping 76 matching lines @@
     poller = try_job_rietveld._RietveldPollerWithCache(TEST_BASE_URL, 60)
     poller.master = self._mockMaster
     poller.setServiceParent(self._mockTJR)
     poller.poll()
     self._mockTJR.clear()
     poller.poll()
     self.assertEquals(len(self._mockTJR.submitted_jobs), 0)
 
   def testDoesNotResubmitJobsAlreadyOnMaster(self):
     poller = try_job_rietveld._RietveldPollerWithCache(TEST_BASE_URL, 60)
-    self._mockMaster.db.buildrequests.addBuildRequest({'buildsetid': 42})
     self._mockMaster.db.buildsets.addBuildSetProperties(
         42, {'try_job_key': ('test_key_1', 'Try bot')})
     poller.master = self._mockMaster
     poller.setServiceParent(self._mockTJR)
     poller.poll()
     self.assertEquals(len(self._mockTJR.submitted_jobs), 1)
     self.assertEquals(self._mockTJR.submitted_jobs[0]['key'], 'test_key_2')
 
+  def testShouldLimitNumberOfBuildsetsUsedForInit(self):
+    self.mock(try_job_rietveld, 'MAX_RECENT_BUILDSETS_TO_INIT_CACHE', 1)
+    poller = try_job_rietveld._RietveldPollerWithCache(TEST_BASE_URL, 60)
+    self._mockMaster.db.buildsets.addBuildSetProperties(
+        24, {'try_job_key': ('test_key_2', 'Try bot')})
+    self._mockMaster.db.buildsets.addBuildSetProperties(
+        42, {'try_job_key': ('test_key_1', 'Try bot')})
+    poller.master = self._mockMaster
+    poller.setServiceParent(self._mockTJR)
+    poller.poll()
+    self.assertEquals(len(self._mockTJR.submitted_jobs), 1)
+    self.assertEquals(self._mockTJR.submitted_jobs[0]['key'], 'test_key_1')
+
 
 if __name__ == '__main__':
   unittest.main()