Issue 305413002: Grow big old generation slower.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305413002: Grow big old generation slower. (Closed)

Created:
6 years, 6 months ago by Hannes Payer (out of office)

Modified:
6 years, 6 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Grow big old generation slower. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21700

Patch Set 3 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -15 lines)			Patch
	M	src/heap.h	View	1 2	2 chunks	+17 lines, -8 lines	0 comments	Download
	M	src/heap.cc	View	1	2 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

lgtm https://codereview.chromium.org/305413002/diff/1/src/heap.h File src/heap.h (right): https://codereview.chromium.org/305413002/diff/1/src/heap.h#newcode1093 src/heap.h:1093: } else if (old_gen_size < max_old_generation_size_/8) { Nit: ...

6 years, 6 months ago (2014-06-05 14:13:11 UTC) #1

Hannes Payer (out of office)

https://codereview.chromium.org/305413002/diff/1/src/heap.h File src/heap.h (right): https://codereview.chromium.org/305413002/diff/1/src/heap.h#newcode1093 src/heap.h:1093: } else if (old_gen_size < max_old_generation_size_/8) { On 2014/06/05 ...

6 years, 6 months ago (2014-06-05 14:46:23 UTC) #2

Hannes Payer (out of office)

6 years, 6 months ago (2014-06-05 15:00:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r21700 (presubmit successful).

Expand Messages | Collapse Messages

Issue 305413002: Grow big old generation slower. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages