Issue 3054042: De-wstringify some browser startup code.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3054042: De-wstringify some browser startup code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Evan Martin

Modified:
4 years ago

Reviewers:
brettw, viettrungluu, Paweł Hajdan Jr.

CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

De-wstringify some browser startup code and net utility. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54860

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -21 lines)			Patch
M	chrome/app/chrome_dll_main.cc	View		3 chunks	+8 lines, -10 lines	0 comments	Download
M	chrome/browser/browser_init.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	net/base/net_util.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/net_util.cc	View		3 chunks	+3 lines, -4 lines	0 comments	Download
M	net/base/net_util_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Trybot results: linux mac win

Total messages: 2 (0 generated)

LGTM