[Mac] Adjust browser-action and content-setting popup points

[Mac] Adjust browser-action and content-setting popup points

Adjust the browser-action popup point to leave the top border of the
window 2px below the bottom border of the Omnibox.  This matches the
Omnibox popup, the bookmark popup, and page-action popups.

Likewise content-setting popup.

BUG=50575
TEST=The popup is spaced correctly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54839

[Scott Hess - ex-Googler, 2010-08-03 19:46:39]

Didn't want to pollute the previous review with the popup positioning.  Also
threw in content-setting popup positioning, which I think covers all the popups.

[Bons, 2010-08-03 21:11:48]

http://codereview.chromium.org/3054040/diff/3001/4001
File chrome/browser/cocoa/extensions/browser_actions_controller.mm (right):

http://codereview.chromium.org/3054040/diff/3001/4001#newcode391
chrome/browser/cocoa/extensions/browser_actions_controller.mm:391:
DCHECK([button isFlipped]);
isFlipped is deprecated on 10.6 so we don't use it. Is there a reason you need
to DCHECK this?

[Bons, 2010-08-03 21:12:01]

LGTM

Sorry forgot to say this. :)

[Scott Hess - ex-Googler, 2010-08-03 21:22:50]

http://codereview.chromium.org/3054040/diff/3001/4001
File chrome/browser/cocoa/extensions/browser_actions_controller.mm (right):

http://codereview.chromium.org/3054040/diff/3001/4001#newcode391
chrome/browser/cocoa/extensions/browser_actions_controller.mm:391:
DCHECK([button isFlipped]);
On 2010/08/03 21:11:49, Andrew Bonventre (Bons) wrote:
> isFlipped is deprecated on 10.6 so we don't use it. Is there a reason you need
> to DCHECK this?

The -isFlipped of the button affects whether the code below needs NSMaxY() or
NSMinY().  I had initially written it to be neutral WRT flipped
(-convertRect:toView: will unflip the rect as necessary, so convert the rect
before finding the point), but that looked cumbersome, too.  I can pull it back
if you'd like.

-[NSImage isFlipped] is deprecated, not -[NSView isFlipped].

[Bons, 2010-08-03 21:40:36]

LGTM

http://codereview.chromium.org/3054040/diff/3001/4001
File chrome/browser/cocoa/extensions/browser_actions_controller.mm (right):

http://codereview.chromium.org/3054040/diff/3001/4001#newcode391
chrome/browser/cocoa/extensions/browser_actions_controller.mm:391:
DCHECK([button isFlipped]);
On 2010/08/03 21:22:50, shess wrote:
> On 2010/08/03 21:11:49, Andrew Bonventre (Bons) wrote:
> > isFlipped is deprecated on 10.6 so we don't use it. Is there a reason you
need
> > to DCHECK this?
> 
> The -isFlipped of the button affects whether the code below needs NSMaxY() or
> NSMinY().  I had initially written it to be neutral WRT flipped
> (-convertRect:toView: will unflip the rect as necessary, so convert the rect
> before finding the point), but that looked cumbersome, too.  I can pull it
back
> if you'd like.
> 
> -[NSImage isFlipped] is deprecated, not -[NSView isFlipped].
Ah you're right. No worries. As needed.
>