Issue 305393003: Fix Chromoting client startup warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305393003: Fix Chromoting client startup warnings. (Closed)

Created:
6 years, 6 months ago by garykac

Modified:
6 years, 6 months ago

Reviewers:
garykac1, Jamie

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix Chromoting client startup warnings. This fixes 2 minor start warnings: * On platforms that have no remapKeys, we used to report a 'bad remapKey' warning. * If there are no hostsettings, then we used to report a 'Not an object' warning when trying to load the host settings. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274472

Patch Set 1 #

Patch Set 2 : Add {} around return for consistency. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
	M	remoting/webapp/client_session.js	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	remoting/webapp/host_settings.js	View		1 chunk	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/305393003/20001

6 years, 6 months ago (2014-06-03 00:22:21 UTC) #4

Message was sent while issue was closed.

Change committed as 274472

Expand Messages | Collapse Messages