Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 305393002: Moving NCN.* histograms to tools/metrics/histograms/histograms.xml (Closed)

Created:
6 years, 6 months ago by jkarlin
Modified:
6 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, jar+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Moving NCN.* histograms to tools/metrics/histograms/histograms.xml BUG=378785 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274585

Patch Set 1 #

Patch Set 2 : Moving the bluetooth histograms to a new cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +387 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jkarlin
Thanks!
6 years, 6 months ago (2014-06-02 13:30:15 UTC) #1
pauljensen
lgtm
6 years, 6 months ago (2014-06-02 13:41:10 UTC) #2
jkarlin
isherman: Please review for OWNERS. Thanks!
6 years, 6 months ago (2014-06-02 15:29:22 UTC) #3
Ilya Sherman
Thanks for moving the histograms over! Please split this CL into two parts: One that's ...
6 years, 6 months ago (2014-06-02 21:12:50 UTC) #4
jkarlin
On 2014/06/02 21:12:50, Ilya Sherman wrote: > Thanks for moving the histograms over! Please split ...
6 years, 6 months ago (2014-06-03 11:10:12 UTC) #5
pauljensen
lgtm
6 years, 6 months ago (2014-06-03 12:04:42 UTC) #6
Ilya Sherman
LGTM. Thanks, Josh!
6 years, 6 months ago (2014-06-03 19:06:50 UTC) #7
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 6 months ago (2014-06-03 19:07:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/305393002/10001
6 years, 6 months ago (2014-06-03 19:07:40 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 19:09:39 UTC) #10
Message was sent while issue was closed.
Change committed as 274585

Powered by Google App Engine
This is Rietveld 408576698