Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2502)

Unified Diff: chrome/browser/media/webrtc_logging_handler_host.cc

Issue 305363004: Fix a bug in passing the RTP header from P2PSocketHost to WebRtcLogggingHandlerHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/webrtc_logging_handler_host.h ('k') | chrome/browser/media/webrtc_rtp_dump_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc_logging_handler_host.cc
diff --git a/chrome/browser/media/webrtc_logging_handler_host.cc b/chrome/browser/media/webrtc_logging_handler_host.cc
index 58386e8a905e0c05a215bdb51a24f2b4564f0b76..4d7b1684254ba5145e03473ec3c5aa19bdc41090 100644
--- a/chrome/browser/media/webrtc_logging_handler_host.cc
+++ b/chrome/browser/media/webrtc_logging_handler_host.cc
@@ -281,21 +281,18 @@ void WebRtcLoggingHandlerHost::StopRtpDump(
rtp_dump_handler_->StopDump(type, callback);
}
-void WebRtcLoggingHandlerHost::OnRtpPacket(const uint8* packet_header,
+void WebRtcLoggingHandlerHost::OnRtpPacket(scoped_ptr<uint8[]> packet_header,
size_t header_length,
size_t packet_length,
bool incoming) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- scoped_ptr<uint8[]> header_data(new uint8[header_length]);
- memcpy(header_data.get(), packet_header, header_length);
-
BrowserThread::PostTask(
BrowserThread::IO,
FROM_HERE,
base::Bind(&WebRtcLoggingHandlerHost::DumpRtpPacketOnIOThread,
this,
- base::Passed(&header_data),
+ base::Passed(&packet_header),
header_length,
packet_length,
incoming));
« no previous file with comments | « chrome/browser/media/webrtc_logging_handler_host.h ('k') | chrome/browser/media/webrtc_rtp_dump_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698