Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 305363003: Oilpan: fix build after r175264. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: fix build after r175264. Finalization of ScreenOrientationController now needed, adjust GC class. R=haraken@chromium.org,ager@chromium.org BUG=162827 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175274

Patch Set 1 #

Patch Set 2 : Tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M Source/modules/screen_orientation/ScreenOrientationController.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
sof
Please take a look.
6 years, 6 months ago (2014-06-02 11:08:32 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-02 11:10:25 UTC) #2
Mads Ager (chromium)
LGTM This is because of the addition of PageLifecycleObserver, right?
6 years, 6 months ago (2014-06-02 11:14:15 UTC) #3
mlamouri (slow - plz ping)
On 2014/06/02 11:14:15, Mads Ager (chromium) wrote: > LGTM > > This is because of ...
6 years, 6 months ago (2014-06-02 11:16:22 UTC) #4
sof
On 2014/06/02 11:14:15, Mads Ager (chromium) wrote: > LGTM > > This is because of ...
6 years, 6 months ago (2014-06-02 11:16:26 UTC) #5
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-06-02 11:16:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/305363003/10001
6 years, 6 months ago (2014-06-02 11:17:01 UTC) #7
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-02 11:17:56 UTC) #8
sof
Thanks for checking the commit button, but I will NOTRY it if the trybot compilations ...
6 years, 6 months ago (2014-06-02 11:18:56 UTC) #9
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-02 11:24:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/305363003/10001
6 years, 6 months ago (2014-06-02 11:24:54 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 11:25:22 UTC) #12
Message was sent while issue was closed.
Change committed as 175274

Powered by Google App Engine
This is Rietveld 408576698