Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 305353002: Clean-up serviceworker-internals page. (Closed)

Created:
6 years, 6 months ago by horo
Modified:
6 years, 6 months ago
Reviewers:
falken
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Clean-up serviceworker-internals page. - Adhere to the 80-column limit - Don't show the partition if there is no registrations nor versions. BUG=358657 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274187

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporated falken's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -112 lines) Patch
M content/browser/resources/service_worker/serviceworker_internals.html View 1 1 chunk +124 lines, -110 lines 0 comments Download
M content/browser/resources/service_worker/serviceworker_internals.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
horo
falken@ Could you please review?
6 years, 6 months ago (2014-06-02 03:56:27 UTC) #1
falken
lgtm with a nit https://codereview.chromium.org/305353002/diff/1/content/browser/resources/service_worker/serviceworker_internals.html File content/browser/resources/service_worker/serviceworker_internals.html (right): https://codereview.chromium.org/305353002/diff/1/content/browser/resources/service_worker/serviceworker_internals.html#newcode95 content/browser/resources/service_worker/serviceworker_internals.html:95: jsdisplay="$this.stored_registrations.length+$this.unregistered_registrations.length+$this.unregistered_versions.length>0"> Other uses of jsdisplay ...
6 years, 6 months ago (2014-06-02 04:19:05 UTC) #2
horo
https://codereview.chromium.org/305353002/diff/1/content/browser/resources/service_worker/serviceworker_internals.html File content/browser/resources/service_worker/serviceworker_internals.html (right): https://codereview.chromium.org/305353002/diff/1/content/browser/resources/service_worker/serviceworker_internals.html#newcode95 content/browser/resources/service_worker/serviceworker_internals.html:95: jsdisplay="$this.stored_registrations.length+$this.unregistered_registrations.length+$this.unregistered_versions.length>0"> On 2014/06/02 04:19:05, falken wrote: > Other uses ...
6 years, 6 months ago (2014-06-02 04:25:32 UTC) #3
horo
The CQ bit was checked by horo@chromium.org
6 years, 6 months ago (2014-06-02 04:25:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/305353002/20001
6 years, 6 months ago (2014-06-02 04:26:00 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 08:17:22 UTC) #6
Message was sent while issue was closed.
Change committed as 274187

Powered by Google App Engine
This is Rietveld 408576698