Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 305343002: Move test-only method from QuicFramer to quic_test_utils. (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Move test-only method from QuicFramer to quic_test_utils. Merge internal change: 68110215 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -96 lines) Patch
M net/quic/quic_connection_test.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M net/quic/quic_framer.h View 1 chunk +0 lines, -7 lines 0 comments Download
M net/quic/quic_framer.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M net/quic/quic_framer_test.cc View 29 chunks +33 lines, -54 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 3 chunks +21 lines, -2 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 6 months ago (2014-06-02 03:45:39 UTC) #1
Ryan Hamilton
6 years, 6 months ago (2014-06-02 15:32:14 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698