Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 305333002: Fix a lint issue with ActivityContentVideoViewClient.java. (Closed)

Created:
6 years, 6 months ago by Sungmann Cho
Modified:
6 years, 6 months ago
Reviewers:
Ted C, qinmin
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix a lint issue with ActivityContentVideoViewClient.java. Currently, the lint warns at: Error: Field requires API level 16 (current min is 14): android.view.View#SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION [InlinedApi] Error: Field requires API level 16 (current min is 14): android.view.View#SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN [InlinedApi] Error: Field requires API level 16 (current min is 14): android.view.View#SYSTEM_UI_FLAG_FULLSCREEN [InlinedApi] So we need to add @SuppressLint("InlinedApi") to suppress these lint errors. BUG=327768 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewClient.java View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Sungmann Cho
Please take a look. Thanks!
6 years, 6 months ago (2014-06-02 02:03:22 UTC) #1
qinmin
lgtm
6 years, 6 months ago (2014-06-02 04:43:35 UTC) #2
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 6 months ago (2014-06-02 07:00:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/305333002/1
6 years, 6 months ago (2014-06-02 07:00:26 UTC) #4
Sungmann Cho
The CQ bit was unchecked by sungmann.cho@navercorp.com
6 years, 6 months ago (2014-06-02 07:23:00 UTC) #5
Ted C
lgtm
6 years, 6 months ago (2014-06-02 17:38:20 UTC) #6
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 6 months ago (2014-06-02 17:38:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/305333002/1
6 years, 6 months ago (2014-06-02 17:41:09 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 17:48:20 UTC) #9
Message was sent while issue was closed. 
Change committed as 274273

Powered by Google App Engine
This is Rietveld 408576698