runtime/lib/object.cc - Issue 30533004: Report correct error message in case of super invocation (fix issue 8208).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/object.cc

Issue 30533004: Report correct error message in case of super invocation (fix issue 8208). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/object.cc

===================================================================

--- runtime/lib/object.cc (revision 29041)

+++ runtime/lib/object.cc (working copy)

@@ -4,6 +4,7 @@

#include "vm/bootstrap_natives.h"

+#include "lib/invocation_mirror.h"

#include "vm/exceptions.h"

#include "vm/heap.h"

#include "vm/native_entry.h"

@@ -61,7 +62,9 @@

dart_arguments.SetAt(3, func_args);

dart_arguments.SetAt(4, func_named_args);

- if (is_method.value()) {

+ if (is_method.value() &&

+ (((invocation_type.Value() >> InvocationMirror::kCallShift) &

+ InvocationMirror::kCallMask) != InvocationMirror::kSuper)) {

// Report if a function with same name (but different arguments) has been

// found.

Function& function = Function::Handle();

« no previous file with comments | « runtime/lib/invocation_mirror_patch.dart ('k') | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »