Issue 3053036: [GTK] Remove reference to obsolete constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3053036: [GTK] Remove reference to obsolete constant. (Closed)

Created:
10 years, 4 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

[GTK] Remove reference to obsolete constant. TBR=ncarter TEST=compile; also autocomplete popup text aligns with omnibox text Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54656

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -13 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc	View		2 chunks	+2 lines, -13 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

http://codereview.chromium.org/3053036/diff/1/2 File chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc (right): http://codereview.chromium.org/3053036/diff/1/2#newcode589 chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc:589: int icon_start_x = ltr ? (kIconLeftPadding) : Nit: Extra ...

10 years, 4 months ago (2010-08-03 01:08:56 UTC) #1

Evan Stade

10 years, 4 months ago (2010-08-03 01:13:17 UTC) #2

On 2010/08/03 01:08:56, Peter Kasting wrote:
> http://codereview.chromium.org/3053036/diff/1/2
> File chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc (right):
> 
> http://codereview.chromium.org/3053036/diff/1/2#newcode589
> chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc:589: int
icon_start_x
> = ltr ? (kIconLeftPadding) :
> Nit: Extra parens

will fix in upcoming toolbar patch

Expand Messages | Collapse Messages