Chromium Code Reviews
Help | Chromium Project | Sign in
(27)

Issue 3053036: [GTK] Remove reference to obsolete constant. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by Evan Stade
Modified:
3 years, 11 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

[GTK] Remove reference to obsolete constant. TBR=ncarter TEST=compile; also autocomplete popup text aligns with omnibox text Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54656

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc View 2 chunks +2 lines, -13 lines 1 comment Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
Peter Kasting
http://codereview.chromium.org/3053036/diff/1/2 File chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc (right): http://codereview.chromium.org/3053036/diff/1/2#newcode589 chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc:589: int icon_start_x = ltr ? (kIconLeftPadding) : Nit: Extra ...
4 years, 10 months ago (2010-08-03 01:08:56 UTC) #1
Evan Stade
4 years, 10 months ago (2010-08-03 01:13:17 UTC) #2
On 2010/08/03 01:08:56, Peter Kasting wrote:
> http://codereview.chromium.org/3053036/diff/1/2
> File chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc (right):
> 
> http://codereview.chromium.org/3053036/diff/1/2#newcode589
> chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc:589: int
icon_start_x
> = ltr ? (kIconLeftPadding) :
> Nit: Extra parens

will fix in upcoming toolbar patch
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be