Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 305283002: [MemSheriff] Disable failing tests. (Closed)

Created:
6 years, 6 months ago by groby-ooo-7-16
Modified:
6 years, 6 months ago
Reviewers:
Lei Zhang, Simon Que
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[MemSheriff] Disable failing tests. Since these tests keep the entire CrOS part of Memory.FYI red, disabling for memcheck. BUG=379140 NOTRY=true R=thestig@chromium.org TBR=sque@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/unit_tests.gtest-memcheck.txt View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
groby-ooo-7-16
6 years, 6 months ago (2014-05-31 01:22:16 UTC) #1
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 6 months ago (2014-05-31 01:22:19 UTC) #2
Simon Que
On 2014/05/31 01:22:19, groby wrote: > The CQ bit was checked by mailto:groby@chromium.org This is ...
6 years, 6 months ago (2014-05-31 01:24:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/305283002/1
6 years, 6 months ago (2014-05-31 01:25:50 UTC) #4
groby-ooo-7-16
Yes, that's the plan. All Memory Sheriff suppressions and disabled tests are supposed to be ...
6 years, 6 months ago (2014-05-31 01:26:35 UTC) #5
groby-ooo-7-16
Oh, and feel free to do the revert yourself once the fix is in. Memory ...
6 years, 6 months ago (2014-05-31 01:27:34 UTC) #6
commit-bot: I haz the power
Change committed as 273979
6 years, 6 months ago (2014-05-31 01:28:44 UTC) #7
Simon Que
Are the memory unit tests run as part of a special test suite? They don't ...
6 years, 6 months ago (2014-05-31 01:29:15 UTC) #8
groby-ooo-7-16
They are part of the memory.fyi tree. http://build.chromium.org/p/chromium.memory.fyi/waterfall They're run outside of the main CQ ...
6 years, 6 months ago (2014-05-31 01:44:17 UTC) #9
Lei Zhang
6 years, 6 months ago (2014-05-31 06:30:13 UTC) #10
Message was sent while issue was closed.
lgtm, but maybe alphabetical order next time?

Powered by Google App Engine
This is Rietveld 408576698