Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 305253002: fix casting issue with or operator (Closed)

Created:
6 years, 6 months ago by djsollen
Modified:
6 years, 6 months ago
Reviewers:
epoger, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

fix casting issue with or operator TBR=reed@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=15011

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/core/SkCanvas.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 6 months ago (2014-05-30 20:55:56 UTC) #1
djsollen
The CQ bit was unchecked by djsollen@google.com
6 years, 6 months ago (2014-05-30 20:55:58 UTC) #2
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 6 months ago (2014-05-30 20:56:38 UTC) #3
djsollen
6 years, 6 months ago (2014-05-30 20:57:00 UTC) #4
reed1
lgtm
6 years, 6 months ago (2014-05-30 20:57:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/305253002/10001
6 years, 6 months ago (2014-05-30 20:58:03 UTC) #6
epoger
Do you think this will fix the red we see on the buildbots right now?
6 years, 6 months ago (2014-05-30 21:00:41 UTC) #7
djsollen
On 2014/05/30 21:00:41, epoger wrote: > Do you think this will fix the red we ...
6 years, 6 months ago (2014-05-30 21:02:48 UTC) #8
djsollen
The CQ bit was unchecked by djsollen@google.com
6 years, 6 months ago (2014-05-30 21:04:39 UTC) #9
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 6 months ago (2014-05-30 21:04:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/305253002/10001
6 years, 6 months ago (2014-05-30 21:05:10 UTC) #11
djsollen
The CQ bit was unchecked by djsollen@google.com
6 years, 6 months ago (2014-05-30 21:06:33 UTC) #12
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 6 months ago (2014-05-30 21:06:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/305253002/10001
6 years, 6 months ago (2014-05-30 21:06:59 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 21:07:07 UTC) #15
Message was sent while issue was closed.
Change committed as 15011

Powered by Google App Engine
This is Rietveld 408576698