Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: ppapi/generators/idl_gen_pnacl.py

Issue 305233002: PPAPI: Make "no_interface_string" APIs have no PNaCl wrapper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review fix Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/generators/idl_gen_wrapper.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/generators/idl_gen_pnacl.py
diff --git a/ppapi/generators/idl_gen_pnacl.py b/ppapi/generators/idl_gen_pnacl.py
index a101341861d9cc2fbf4d0c0c47674538d12fd80a..dd1ce0cd9eb7ef909e70882be4f2e5ad7a2a3165 100755
--- a/ppapi/generators/idl_gen_pnacl.py
+++ b/ppapi/generators/idl_gen_pnacl.py
@@ -59,6 +59,12 @@ class PnaclGen(WrapperGen):
return True
if iface.GetName().endswith('Trusted'):
return False
+ # TODO(dmichael): We have no way to wrap PPP_ interfaces without an
+ # interface string. If any ever need wrapping, we'll need to figure out a
+ # way to get the plugin-side of the Pepper proxy (within the IRT) to access
+ # and use the wrapper.
+ if iface.GetProperty("no_interface_string"):
+ return False
for member in iface.GetListOf('Member'):
release = member.GetRelease(version)
if self.MemberNeedsWrapping(member, release):
« no previous file with comments | « no previous file | ppapi/generators/idl_gen_wrapper.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698