Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 305233002: PPAPI: Make "no_interface_string" APIs have no PNaCl wrapper (Closed)

Created:
6 years, 6 months ago by dmichael (off chromium)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

PPAPI: Make "no_interface_string" APIs have no PNaCl wrapper BUG=367896 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274034

Patch Set 1 #

Total comments: 1

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M ppapi/generators/idl_gen_pnacl.py View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ppapi/generators/idl_gen_wrapper.py View 1 chunk +1 line, -3 lines 0 comments Download
M ppapi/generators/test_gen_pnacl/test_interfaces.idl View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dmichael (off chromium)
6 years, 6 months ago (2014-05-30 20:22:28 UTC) #1
teravest
lgtm https://codereview.chromium.org/305233002/diff/1/ppapi/generators/idl_gen_pnacl.py File ppapi/generators/idl_gen_pnacl.py (right): https://codereview.chromium.org/305233002/diff/1/ppapi/generators/idl_gen_pnacl.py#newcode62 ppapi/generators/idl_gen_pnacl.py:62: # TODO(dmichael): nit: Usually the TODO paragraph on ...
6 years, 6 months ago (2014-05-30 20:24:57 UTC) #2
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 6 months ago (2014-05-30 20:47:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/305233002/20001
6 years, 6 months ago (2014-05-30 20:51:24 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-31 02:25:25 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 05:01:58 UTC) #6
Message was sent while issue was closed.
Change committed as 274034

Powered by Google App Engine
This is Rietveld 408576698