Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 305213002: Do not mark QUIC as *broken* when a 0-RTT fails because this prevents us (Closed)

Created:
6 years, 6 months ago by Ryan Hamilton
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Do not mark QUIC as *broken* when a 0-RTT fails because this prevents us from verifying that TCP is also working. So instead, mark it as "recently broken" which requires handshake confirmation. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -15 lines) Patch
M net/http/http_server_properties_impl.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 chunk +28 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ryan Hamilton
6 years, 6 months ago (2014-05-30 18:34:36 UTC) #1
ramant (doing other things)
lgtm
6 years, 6 months ago (2014-05-30 21:16:00 UTC) #2
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 6 months ago (2014-05-30 21:19:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/305213002/1
6 years, 6 months ago (2014-05-30 21:22:30 UTC) #4
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 6 months ago (2014-05-30 22:37:34 UTC) #5
Ryan Hamilton
The CQ bit was unchecked by rch@chromium.org
6 years, 6 months ago (2014-05-30 22:37:34 UTC) #6
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 6 months ago (2014-05-30 22:37:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/305213002/1
6 years, 6 months ago (2014-05-30 22:45:02 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 04:16:09 UTC) #9
Message was sent while issue was closed.
Change committed as 274010

Powered by Google App Engine
This is Rietveld 408576698