Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 305203002: Use GrGLShaderBuilder::GenProgramOutput in GrGLProgram. (Closed)

Created:
6 years, 6 months ago by bsalomon
Modified:
6 years, 6 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Use GrGLShaderBuilder::GenProgramOutput in GrGLProgram. Committed: http://code.google.com/p/skia/source/detail?r=15002

Patch Set 1 #

Patch Set 2 : restore autotunref #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -72 lines) Patch
M src/gpu/gl/GrGLProgram.h View 1 3 chunks +8 lines, -17 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 7 chunks +35 lines, -39 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 1 chunk +20 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 chunk +7 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
The last purely refactoring CL for builder/program (for now).
6 years, 6 months ago (2014-05-30 18:14:59 UTC) #1
robertphillips
lgtm
6 years, 6 months ago (2014-05-30 18:48:32 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 6 months ago (2014-05-30 18:49:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/305203002/20001
6 years, 6 months ago (2014-05-30 18:49:44 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 18:55:06 UTC) #5
Message was sent while issue was closed.
Change committed as 15002

Powered by Google App Engine
This is Rietveld 408576698