Source/core/rendering/shapes/ShapeOutsideInfo.h - Issue 305173003: Heap-use-after-free in WebCore::GraphicsContext::drawImage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/shapes/ShapeOutsideInfo.h

Issue 305173003: Heap-use-after-free in WebCore::GraphicsContext::drawImage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed a spurious .get() Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/shapes/shape-outside-floats/shape-outside-uncached-gradient-expected.txt ('k') | Source/core/rendering/shapes/ShapeOutsideInfo.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/shapes/ShapeOutsideInfo.h

diff --git a/Source/core/rendering/shapes/ShapeOutsideInfo.h b/Source/core/rendering/shapes/ShapeOutsideInfo.h

index cbc95acc66b23c8921785a9ec0e046fcff67a102..36276e91fdb628b98a17c55150f0bad29819dc27 100644

--- a/Source/core/rendering/shapes/ShapeOutsideInfo.h

+++ b/Source/core/rendering/shapes/ShapeOutsideInfo.h

@@ -101,6 +101,8 @@ protected:

{ }

private:

+ PassOwnPtr<Shape> createShapeForImage(StyleImage*, float shapeImageThreshold, WritingMode, float margin) const;

LayoutUnit logicalTopOffset() const;

LayoutUnit logicalLeftOffset() const;