Issue 305153002: Fix for flag-file covering Rollback reset option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305153002: Fix for flag-file covering Rollback reset option. (Closed)

Created:
6 years, 6 months ago by merkulova

Modified:
6 years, 6 months ago

Reviewers:
dzhioev (left Google)

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix for flag-file covering Rollback reset option. BUG=368844 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273884

Patch Set 2 : Nit #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dzhioev (left Google)

LGTM with nit https://codereview.chromium.org/305153002/diff/1/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc (right): https://codereview.chromium.org/305153002/diff/1/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc#newcode143 chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc:143: if (!(*file_exists.get()) && !CommandLine::ForCurrentProcess()->HasSwitch( nit: .get() ...

6 years, 6 months ago (2014-05-30 09:27:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/305153002/20001

6 years, 6 months ago (2014-05-30 15:20:13 UTC) #5

Message was sent while issue was closed.

Change committed as 273884

Expand Messages | Collapse Messages

Issue 305153002: Fix for flag-file covering Rollback reset option. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Nit #

Messages