Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 305143002: Don't call moveParagraph() with null |VisiblePositon| (Closed)

Created:
6 years, 6 months ago by yosin_UTC9
Modified:
6 years, 6 months ago
Reviewers:
yoichio, Yuta Kitamura
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Don't call moveParagraph() with null |VisiblePositon| This patch changes |IndentOutdentCommand::outdentParagraph()| not to call |CompositeEditCommand::movePargrap()| with null |VisiblePositon|. This situation can be happened in attached test case, where |visibleStartOfParagraph| and |visibleEndOfPargraph| are second TABLE element. Both |startOfParagraph()| and |endOfParagraph()| return null |VisiblePositon| for them. BUG=379058 TEST=editing/execCommand/outdent-collapse-table-crash-2.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175258

Patch Set 1 : 2014-05-30T05:23:36 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
A LayoutTests/editing/execCommand/outdent-collapse-table-crash-2.html View 1 chunk +32 lines, -0 lines 0 comments Download
A + LayoutTests/editing/execCommand/outdent-collapse-table-crash-2-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/editing/IndentOutdentCommand.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance. Note: Compilation failures of mac_blink_rel, blink_android_compile_{dbg,rel} aren't ...
6 years, 6 months ago (2014-06-02 00:49:03 UTC) #1
Yuta Kitamura
lgtm
6 years, 6 months ago (2014-06-02 06:22:21 UTC) #2
yosin_UTC9
The CQ bit was checked by yosin@chromium.org
6 years, 6 months ago (2014-06-02 06:49:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/305143002/20001
6 years, 6 months ago (2014-06-02 06:50:09 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 08:51:10 UTC) #5
Message was sent while issue was closed.
Change committed as 175258

Powered by Google App Engine
This is Rietveld 408576698