src/effects/SkAlphaThresholdFilter.cpp - Issue 305133006: use colortype instead of config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkAlphaThresholdFilter.cpp

Issue 305133006: use colortype instead of config (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkAlphaThresholdFilter.cpp

diff --git a/src/effects/SkAlphaThresholdFilter.cpp b/src/effects/SkAlphaThresholdFilter.cpp

index 205e9a9516058f946279ea35b486b352f0bcd7e5..c19083e12d1ea9968ce50e75fdf35aeff6f629ea 100644

--- a/src/effects/SkAlphaThresholdFilter.cpp

+++ b/src/effects/SkAlphaThresholdFilter.cpp

@@ -323,8 +323,7 @@ bool SkAlphaThresholdFilterImpl::onFilterImage(Proxy*, const SkBitmap& src,

return false;

}

robertphillips 2014/06/02 13:15:59 This seems odd. Why not just "allocPixels(src.info

reed1 2014/06/02 19:43:06 Ah, right, I didn't see that src == src... :(

- dst->setConfig(src.config(), src.width(), src.height());

- if (!dst->allocPixels()) {

+ if (!dst->allocPixels(src.info().makeWH(src.width(), src.height()))) {

return false;

}