Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 305133006: use colortype instead of config (Closed)

Created:
6 years, 6 months ago by reed1
Modified:
6 years, 6 months ago
Reviewers:
scroggo, robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

use colortype instead of config closed in favor of https://codereview.chromium.org/301233011 (was based on svn version)

Patch Set 1 #

Total comments: 18

Patch Set 2 : rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -76 lines) Patch
M include/core/SkImageInfo.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkBicubicImageFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSE2.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSSE3.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_arm.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/opts/SkBlitMask_opts_arm.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFImage.cpp View 11 chunks +29 lines, -31 lines 0 comments Download
M src/utils/SkBitmapHasher.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkBitmapHasher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkPictureUtils.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/debugger/SkObjectParser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/debugger/SkObjectParser.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
reed1
6 years, 6 months ago (2014-05-31 03:12:52 UTC) #1
robertphillips
lgtm + a couple of questions https://codereview.chromium.org/305133006/diff/1/src/effects/SkAlphaThresholdFilter.cpp File src/effects/SkAlphaThresholdFilter.cpp (right): https://codereview.chromium.org/305133006/diff/1/src/effects/SkAlphaThresholdFilter.cpp#newcode325 src/effects/SkAlphaThresholdFilter.cpp:325: This seems odd. ...
6 years, 6 months ago (2014-06-02 13:15:59 UTC) #2
scroggo
https://codereview.chromium.org/305133006/diff/1/src/pdf/SkPDFImage.cpp File src/pdf/SkPDFImage.cpp (left): https://codereview.chromium.org/305133006/diff/1/src/pdf/SkPDFImage.cpp#oldcode595 src/pdf/SkPDFImage.cpp:595: // TODO(edisonn) It fails only for kA1_Config, if that ...
6 years, 6 months ago (2014-06-02 13:35:07 UTC) #3
reed1
https://codereview.chromium.org/305133006/diff/1/src/pdf/SkPDFImage.cpp File src/pdf/SkPDFImage.cpp (left): https://codereview.chromium.org/305133006/diff/1/src/pdf/SkPDFImage.cpp#oldcode595 src/pdf/SkPDFImage.cpp:595: // TODO(edisonn) It fails only for kA1_Config, if that ...
6 years, 6 months ago (2014-06-02 18:41:33 UTC) #4
scroggo
On 2014/06/02 18:41:33, reed1 wrote: > https://codereview.chromium.org/305133006/diff/1/src/pdf/SkPDFImage.cpp > File src/pdf/SkPDFImage.cpp (left): > > https://codereview.chromium.org/305133006/diff/1/src/pdf/SkPDFImage.cpp#oldcode595 > ...
6 years, 6 months ago (2014-06-02 18:42:35 UTC) #5
reed1
https://codereview.chromium.org/305133006/diff/1/src/effects/SkAlphaThresholdFilter.cpp File src/effects/SkAlphaThresholdFilter.cpp (right): https://codereview.chromium.org/305133006/diff/1/src/effects/SkAlphaThresholdFilter.cpp#newcode325 src/effects/SkAlphaThresholdFilter.cpp:325: On 2014/06/02 13:15:59, robertphillips wrote: > This seems odd. ...
6 years, 6 months ago (2014-06-02 19:43:06 UTC) #6
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-02 19:53:35 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 19:54:11 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 19:54:12 UTC) #9 
Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

Powered by Google App Engine
This is Rietveld 408576698