Issue 305133004: Eliminate url() method on TimelineModel.Record

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305133004: Eliminate url() method on TimelineModel.Record (Closed)

Created:
6 years, 6 months ago by yurys

Modified:
6 years, 6 months ago

Reviewers:
caseq, alph, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Eliminate url() method on TimelineModel.Record All its usages have been inlined. BUG=361045 R=alph@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175263

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -24 lines)			Patch
	M	Source/devtools/front_end/timeline/TimelineModel.js	View		2 chunks	+0 lines, -18 lines	0 comments	Download
	M	Source/devtools/front_end/timeline/TimelineUIUtils.js	View		3 chunks	+17 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/305133004/1

6 years, 6 months ago (2014-06-02 07:05:31 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...

6 years, 6 months ago (2014-06-02 08:36:05 UTC) #5

yurys

6 years, 6 months ago (2014-06-02 09:18:17 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r175263 (presubmit successful).

Expand Messages | Collapse Messages