ui/app_list/views/start_page_view.cc - Issue 305123002: Fix crash in the experimental app list StartPageView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/views/start_page_view.cc

Issue 305123002: Fix crash in the experimental app list StartPageView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add profile change tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/app_list/views/start_page_view.cc

diff --git a/ui/app_list/views/start_page_view.cc b/ui/app_list/views/start_page_view.cc

index 7cff74e209e108213813c00cc7b836fd3cc266d4..a460ad16ff6986aa2e88242e53db8bfdb90977e7 100644

--- a/ui/app_list/views/start_page_view.cc

+++ b/ui/app_list/views/start_page_view.cc

@@ -121,6 +121,8 @@ StartPageView::StartPageView(AppListMainView* app_list_main_view,

StartPageView::~StartPageView() {

view_delegate_->RemoveObserver(this);

+ if (model_)

+ model_->RemoveObserver(this);

}

void StartPageView::SetModel(AppListModel* model) {

« ui/app_list/views/app_list_view_unittest.cc ('K') | « ui/app_list/views/app_list_view_unittest.cc ('k') | no next file » | no next file with comments »