Fix crash in the experimental app list StartPageView.

ui/app_list/views/app_list_view_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/app_list_view.h"
 
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/strings/string_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 58 matching lines @@
   // top level views. Then closes the window.
   void RunDisplayTest();
 
   // Hides and reshows the app list with a folder open, expecting the main grid
   // view to be shown.
   void RunReshowWithOpenFolderTest();
 
   // Tests displaying of the experimental app list and shows the start page.
   void RunStartPageTest();
 
+  // Tests that changing the App List profile.
+  void RunProfileChangeTest();
+
   // A standard set of checks on a view, e.g., ensuring it is drawn and visible.
   static void CheckView(views::View* subview);
 
   // Invoked when the Widget is closing, and the view it contains is about to
   // be torn down. This only occurs in a run loop and will be used as a signal
   // to quit.
   void NativeWidgetClosing() {
     view_ = NULL;
     run_loop_->Quit();
   }
@@ skipping 205 matching lines @@
     EXPECT_EQ(4u, GetVisibleTileItemViews(start_page_view->tile_views()));
     model->DeleteItem(model->GetItemName(0));
     EXPECT_EQ(3u, GetVisibleTileItemViews(start_page_view->tile_views()));
   } else {
     EXPECT_EQ(NULL, start_page_view);
   }
 
   Close();
 }
 
+void AppListViewTestContext::RunProfileChangeTest() {
+  EXPECT_FALSE(view_->GetWidget()->IsVisible());
+  EXPECT_EQ(-1, pagination_model_.total_pages());
+  delegate_->GetTestModel()->PopulateApps(kInitialItems);
+
+  Show();
+
+  if (is_landscape())
+    EXPECT_EQ(2, pagination_model_.total_pages());
+  else
+    EXPECT_EQ(3, pagination_model_.total_pages());
+
+  AppListMainView* main_view = view_->app_list_main_view();

[tapted, 2014/05/30 09:01:39]

nit: these 4 lines are probably redundant; being run in RunDisplayTest().

The pagination model checks are probably good to keep though, since it's used
later.

+  // Checks on the main view.
+  EXPECT_NO_FATAL_FAILURE(CheckView(main_view));
+  EXPECT_NO_FATAL_FAILURE(CheckView(main_view->contents_view()));
+
+  // Change the profile. The original model needs to be kept alive for
+  // observers to unregister themselves.
+  scoped_ptr<AppListTestModel> original_test_model(
+      delegate_->ReleaseTestModel());
+  delegate_->set_next_profile_app_count(1);
+
+  // The original ContentsView is destroyed here.
+  view_->SetProfileByPath(base::FilePath());
+  EXPECT_EQ(1, pagination_model_.total_pages());
+
+  StartPageView* start_page_view =
+      main_view->contents_view()->start_page_view();
+  if (test_type_ == EXPERIMENTAL) {
+    EXPECT_NO_FATAL_FAILURE(CheckView(start_page_view));
+    EXPECT_EQ(1u, GetVisibleTileItemViews(start_page_view->tile_views()));
+  } else {
+    EXPECT_EQ(NULL, start_page_view);
+  }
+
+  // New model updates should be processed by the start page view.
+  delegate_->GetTestModel()->CreateAndAddItem("Test App");
+  if (test_type_ == EXPERIMENTAL)
+    EXPECT_EQ(2u, GetVisibleTileItemViews(start_page_view->tile_views()));
+
+  // Old model updates should be ignored.
+  original_test_model->CreateAndAddItem("Test App 2");
+  if (test_type_ == EXPERIMENTAL)
+    EXPECT_EQ(2u, GetVisibleTileItemViews(start_page_view->tile_views()));
+
+  Close();
+}
+
 class AppListViewTestAura : public views::ViewsTestBase,
                             public ::testing::WithParamInterface<int> {
  public:
   AppListViewTestAura() {}
   virtual ~AppListViewTestAura() {}
 
   // testing::Test overrides:
   virtual void SetUp() OVERRIDE {
     views::ViewsTestBase::SetUp();
     test_context_.reset(new AppListViewTestContext(GetParam(), GetContext()));
@@ skipping 93 matching lines @@
 
 // Tests that the start page view operates correctly.
 TEST_P(AppListViewTestAura, StartPageTest) {
   EXPECT_NO_FATAL_FAILURE(test_context_->RunStartPageTest());
 }
 
 TEST_P(AppListViewTestDesktop, StartPageTest) {
   EXPECT_NO_FATAL_FAILURE(test_context_->RunStartPageTest());
 }
 
+// Tests that the profile changes operate correctly.
+TEST_P(AppListViewTestAura, ProfileChangeTest) {
+  EXPECT_NO_FATAL_FAILURE(test_context_->RunProfileChangeTest());
+}
+
+TEST_P(AppListViewTestDesktop, ProfileChangeTest) {
+  EXPECT_NO_FATAL_FAILURE(test_context_->RunProfileChangeTest());
+}
+
 INSTANTIATE_TEST_CASE_P(AppListViewTestAuraInstance,
                         AppListViewTestAura,
                         ::testing::Range<int>(TEST_TYPE_START, TEST_TYPE_END));
 
 INSTANTIATE_TEST_CASE_P(AppListViewTestDesktopInstance,
                         AppListViewTestDesktop,
                         ::testing::Range<int>(TEST_TYPE_START, TEST_TYPE_END));
 
 }  // namespace test
 }  // namespace app_list