Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 305103006: Update the string for gaia incognito header (Closed)

Created:
6 years, 6 months ago by guohui
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Update the string for gaia incognito header BUG=375416 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274030

Patch Set 1 #

Patch Set 2 : histogram xml updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/profiles/profile_metrics.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_header_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_header_helper.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
guohui
Hey, could you please take a look at the cl? Thanks, Hui
6 years, 6 months ago (2014-05-30 18:14:00 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 6 months ago (2014-05-30 18:24:18 UTC) #2
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 6 months ago (2014-05-30 18:28:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/305103006/20001
6 years, 6 months ago (2014-05-30 18:28:48 UTC) #4
guohui
+noms@ for owner review of chrome/browser/profiles/profile_metrics.cc +asvitkine@ for owner review of tools/metrics/histograms/histograms.xml
6 years, 6 months ago (2014-05-30 20:20:19 UTC) #5
guohui
The CQ bit was unchecked by guohui@chromium.org
6 years, 6 months ago (2014-05-30 20:20:24 UTC) #6
Alexei Svitkine (slow)
Was the old option simply named incorrectly or is it changing in meaning? The reason ...
6 years, 6 months ago (2014-05-30 20:24:52 UTC) #7
noms (inactive)
profiles lgtm
6 years, 6 months ago (2014-05-30 20:27:27 UTC) #8
guohui
It was simply named incorrectly.
6 years, 6 months ago (2014-05-30 20:46:39 UTC) #9
Alexei Svitkine (slow)
gotcha, LGTM
6 years, 6 months ago (2014-05-30 20:47:31 UTC) #10
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 6 months ago (2014-05-30 20:56:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/305103006/20001
6 years, 6 months ago (2014-05-30 20:59:36 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 04:56:10 UTC) #13
Message was sent while issue was closed.
Change committed as 274030

Powered by Google App Engine
This is Rietveld 408576698