Issue 305093002: views: Make BookmarkBarViewTest12.CloseWithModalDialog more predictable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305093002: views: Make BookmarkBarViewTest12.CloseWithModalDialog more predictable. (Closed)

Created:
6 years, 6 months ago by sadrul

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Make BookmarkBarViewTest12.CloseWithModalDialog more predictable. The test currently depends on timers in a few places. Replace those with more deterministic behaviour by using the appropriate observers to make sure that the message-box dialog shows up, the dialog receives the tab key event, and the dialog is terminated correctly. BUG=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273716

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -27 lines)			Patch
	M	chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc	View		4 chunks	+170 lines, -27 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

6 years, 6 months ago (2014-05-30 05:20:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r273716 (presubmit successful).

Expand Messages | Collapse Messages