Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 305053004: Use .volume_label property for notifying MTP volume labels. (Closed)

Created:
6 years, 6 months ago by kinaba
Modified:
6 years, 6 months ago
Reviewers:
hirono
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Use .volume_label property for notifying MTP volume labels. Previously we've abused .volume_id for the purpose, but now we have a dedicated field for the volume name. Now the .volume_id field can be arbitrary human unreadable string, but I'd like to keep it as in the current form since there's also no other reason to make it cryptic. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/chromeos/file_manager/volume_manager.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinaba
6 years, 6 months ago (2014-05-30 04:35:37 UTC) #1
hirono
lgtm!
6 years, 6 months ago (2014-05-30 04:39:44 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 6 months ago (2014-05-30 04:42:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/305053004/1
6 years, 6 months ago (2014-05-30 04:44:06 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 10:18:11 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 14:28:08 UTC) #6
Message was sent while issue was closed.
Change committed as 273826

Powered by Google App Engine
This is Rietveld 408576698