Added xdisplaycheck target to browser_tests deps

Added xdisplaycheck target to browser_tests deps

browser_tests require xdisplaycheck to run, but the target does not list
xdisplaycheck as a dependency.

R=mseaborn@chromium.org, vadimsh@chromium.org
BUG=359338
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274078

[Vadim Sh., 2014-05-30 20:57:13]

https://codereview.chromium.org/305053002/diff/20001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/305053002/diff/20001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:840:
'../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck',
Other targets list it in ['use_x11==1', {...}] section. browser_tests should do
the same, I think.

[nodir, 2014-05-30 21:03:08]

https://codereview.chromium.org/305053002/diff/20001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/305053002/diff/20001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:840:
'../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck',
On 2014/05/30 20:57:13, Vadim Sh. wrote:
> Other targets list it in ['use_x11==1', {...}] section. browser_tests should
do
> the same, I think.

Done.

[Vadim Sh., 2014-05-30 21:06:44]

lgtm

Also launched a bunch of try bots to verify.

[nodir, 2014-05-30 21:57:02]

On 2014/05/30 21:06:44, Vadim Sh. wrote:
> lgtm
> 
> Also launched a bunch of try bots to verify.

The AttributeError happened in IsolateApi.isolated_tests again
http://build.chromium.org/p/tryserver.chromium/builders/linux_arm_tester/buil...
PTAL

[nodir, 2014-05-30 21:58:55]

It didn't find .isolated files, obviously, because browser_tests_run is not
specified. I am testing this case on my machine

[nodir, 2014-05-30 21:59:12]

On 2014/05/30 21:58:55, nodir wrote:
> It didn't find .isolated files, obviously, because browser_tests_run is not
> specified. I am testing this case on my machine

I mean, on ARM
http://build.chromium.org/p/tryserver.chromium/builders/linux_arm_cross_compi...

[nodir, 2014-05-31 00:05:53]

Locally, it generates an .isolated file with hash
d50f2026d49d3c9316b5a719097fd800f448494a
But when I run 
$ run_isolated.py --isolate-server=http://isolateserver.appspot.com -H
d50f2026d49d3c9316b5a719097fd800f448494a
it says 
  Failed to load ../out/Release/xdisplaycheck with
cwd=/usr/local/google/home/nodir/cr/tmp/isolated_run/run_tha_testJu5FXU/chrome
again

At the same time I have xdispaycheck in
build/slave/fake_slave/build/src/out/Release

[nodir, 2014-05-31 00:40:00]

Offline, Vadim realized that it couldn't run on my machine because it is
compiled for ARM.

Running it on an ARM machine worked:
$ /b/build/slave/linux_arm_tester/build/swarming.client/run_isolated.py
--isolate-server=http://isolateserver.appspot.com -H
d50f2026d49d3c9316b5a719097fd800f448494a -- --gtest-filter=*NaCl*

[nodir, 2014-05-31 00:41:06]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2014-05-31 00:46:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nodir@chromium.org/305053002/40001

[commit-bot: I haz the power, 2014-05-31 22:37:18]

Change committed as 274078