Issue 305033011: QUIC flow control now based on highest received byte offset rather than

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305033011: QUIC flow control now based on highest received byte offset rather than (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)

Modified:
6 years, 6 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

QUIC flow control now based on highest received byte offset rather than bytes buffered. No longer keep track of how many bytes we have buffered in the QUIC flow controller - this adds complexity when we can just track the highest received byte offset. This allows us to detect flow control violation earlier. QUIC flow control now based on highest received byte offset rather than bytes buffered. Protected behind (already ENABLEd) FLAGS_enable_quic_stream_flow_control_2 Merge internal change: 68200399 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -69 lines)			Patch
M	net/quic/quic_flow_controller.h	View	3 chunks	+12 lines, -10 lines	0 comments	Download
M	net/quic/quic_flow_controller.cc	View	4 chunks	+17 lines, -29 lines	0 comments	Download
M	net/quic/quic_flow_controller_test.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	net/quic/quic_stream_sequencer.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	net/quic/reliable_quic_stream.h	View	2 chunks	+3 lines, -11 lines	0 comments	Download
M	net/quic/reliable_quic_stream.cc	View	3 chunks	+18 lines, -11 lines	0 comments	Download
M	net/quic/test_tools/quic_flow_controller_peer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages