Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 305033004: SVG: Remove&inline |invokeMethodOnAllTargetProperties| (Closed)

Created:
6 years, 6 months ago by kouhei (in TOK)
Modified:
6 years, 6 months ago
Reviewers:
haraken, pdr.
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, Eric Willigers
Visibility:
Public.

Description

SVG: Remove&inline |invokeMethodOnAllTargetProperties| |invokeMethodOnAllTargetProperties| is now only used from |endAnimation|. The code is more readable when inlined. BUG=378670 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175125

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M Source/core/svg/SVGAnimatedTypeAnimator.cpp View 2 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
kouhei (in TOK)
This is based on pdr's comment on https://codereview.chromium.org/304863002/ Would you take a look?
6 years, 6 months ago (2014-05-30 01:49:43 UTC) #1
pdr.
On 2014/05/30 01:49:43, kouhei wrote: > This is based on pdr's comment on https://codereview.chromium.org/304863002/ > ...
6 years, 6 months ago (2014-05-30 02:24:10 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 6 months ago (2014-05-30 02:24:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/305033004/1
6 years, 6 months ago (2014-05-30 02:25:20 UTC) #4
haraken
LGTM
6 years, 6 months ago (2014-05-30 02:52:32 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-30 09:18:39 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 09:56:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9575)
6 years, 6 months ago (2014-05-30 09:56:44 UTC) #8
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 6 months ago (2014-05-30 12:30:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/305033004/1
6 years, 6 months ago (2014-05-30 12:31:51 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 13:18:39 UTC) #11
Message was sent while issue was closed.
Change committed as 175125

Powered by Google App Engine
This is Rietveld 408576698