Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 305033002: TSAN caught us racing in ScalarBench.cpp (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix windows? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M bench/ScalarBench.cpp View 1 3 chunks +11 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
mtklein
6 years, 6 months ago (2014-05-29 20:35:03 UTC) #1
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-05-30 14:50:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/305033002/1
6 years, 6 months ago (2014-05-30 14:50:34 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 14:50:35 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-05-30 14:50:35 UTC) #5
mtklein
lgtm
6 years, 6 months ago (2014-05-30 14:51:22 UTC) #6
reed1
lgtm
6 years, 6 months ago (2014-05-30 14:53:37 UTC) #7
commit-bot: I haz the power
Change committed as 14992
6 years, 6 months ago (2014-05-30 14:57:00 UTC) #8
mtklein
A revert of this CL has been created in https://codereview.chromium.org/308883003/ by mtklein@google.com. The reason for ...
6 years, 6 months ago (2014-05-30 15:09:22 UTC) #9
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-02 19:35:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/305033002/20001
6 years, 6 months ago (2014-06-02 19:36:00 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 19:41:11 UTC) #12
Message was sent while issue was closed.
Change committed as 80f709a0d7f2f1d0d35a292c0c3189d3a50b4993

Powered by Google App Engine
This is Rietveld 408576698