Issue 305013015: Mojo: (Mostly) factor out command-line switches from the shell's load code path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305013015: Mojo: (Mostly) factor out command-line switches from the shell's load code path. (Closed)

Created:
6 years, 6 months ago by viettrungluu

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: (Mostly) factor out command-line switches from the shell's load code path. (Still to do: switches::kDisableCache.) This is to make the shell more testable. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274373

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -36 lines)			Patch
M	mojo/shell/android/mojo_main.cc	View	2 chunks	+4 lines, -10 lines	0 comments	Download
M	mojo/shell/context.h	View	3 chunks	+10 lines, -0 lines	0 comments	Download
M	mojo/shell/desktop/mojo_main.cc	View	2 chunks	+21 lines, -2 lines	0 comments	Download
M	mojo/shell/dynamic_service_loader.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	mojo/shell/run.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	mojo/shell/run.cc	View	1 chunk	+9 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years, 6 months ago (2014-06-02 23:52:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r274373 (presubmit successful).

Expand Messages | Collapse Messages