DevTools: DevToolsAndroidBridge polling loops

DevTools: DevToolsAndroidBridge polling loops

Based on:
https://codereview.chromium.org/286993003/

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274611

[Vladislav Kaznacheev, 2014-06-02 18:09:43]

https://chromiumcodereview.appspot.com/305013013/diff/80001/chrome/browser/de...
File chrome/browser/devtools/device/devtools_android_bridge.cc (right):

https://chromiumcodereview.appspot.com/305013013/diff/80001/chrome/browser/de...
chrome/browser/devtools/device/devtools_android_bridge.cc:802:
RequestDeviceCount(device_count_callback_.callback());
I do not see the reason not to extract the 3 lines above into
StartDeviceCountPolling method.

https://chromiumcodereview.appspot.com/305013013/diff/80001/chrome/browser/de...
chrome/browser/devtools/device/devtools_android_bridge.cc:814:
device_count_callback_.Cancel();
Although it is just a single line, it would look cleaner extracted into
StopDeviceCountPolling method.

https://chromiumcodereview.appspot.com/305013013/diff/80001/chrome/browser/de...
chrome/browser/devtools/device/devtools_android_bridge.cc:899: if
(!device_count_scheduler_for_test_.is_null()) {
I have an idea:
1. Call this member |task_scheduler_|
2. Initialize it with a shortcut to PostDelayedTask
3. Use it directly here and when scheduling device list request (you are going
to need that for device list test anyway).

https://chromiumcodereview.appspot.com/305013013/diff/80001/chrome/browser/de...
File chrome/browser/devtools/device/usb/devtools_android_bridge_browsertest.cc
(right):

https://chromiumcodereview.appspot.com/305013013/diff/80001/chrome/browser/de...
chrome/browser/devtools/device/usb/devtools_android_bridge_browsertest.cc:251: }
Lets test device list listeners as well. Maybe in a separate patch.

[vkuzkokov, 2014-06-03 09:20:50]

https://chromiumcodereview.appspot.com/305013013/diff/80001/chrome/browser/de...
File chrome/browser/devtools/device/devtools_android_bridge.cc (right):

https://chromiumcodereview.appspot.com/305013013/diff/80001/chrome/browser/de...
chrome/browser/devtools/device/devtools_android_bridge.cc:802:
RequestDeviceCount(device_count_callback_.callback());
On 2014/06/02 18:09:43, Vladislav Kaznacheev wrote:
> I do not see the reason not to extract the 3 lines above into
> StartDeviceCountPolling method.

Done.

https://chromiumcodereview.appspot.com/305013013/diff/80001/chrome/browser/de...
chrome/browser/devtools/device/devtools_android_bridge.cc:814:
device_count_callback_.Cancel();
On 2014/06/02 18:09:43, Vladislav Kaznacheev wrote:
> Although it is just a single line, it would look cleaner extracted into
> StopDeviceCountPolling method.

Done.

https://chromiumcodereview.appspot.com/305013013/diff/80001/chrome/browser/de...
chrome/browser/devtools/device/devtools_android_bridge.cc:899: if
(!device_count_scheduler_for_test_.is_null()) {
On 2014/06/02 18:09:43, Vladislav Kaznacheev wrote:
> I have an idea:
> 1. Call this member |task_scheduler_|
> 2. Initialize it with a shortcut to PostDelayedTask
> 3. Use it directly here and when scheduling device list request (you are going
> to need that for device list test anyway).

Done.

https://chromiumcodereview.appspot.com/305013013/diff/80001/chrome/browser/de...
File chrome/browser/devtools/device/usb/devtools_android_bridge_browsertest.cc
(right):

https://chromiumcodereview.appspot.com/305013013/diff/80001/chrome/browser/de...
chrome/browser/devtools/device/usb/devtools_android_bridge_browsertest.cc:251: }
On 2014/06/02 18:09:43, Vladislav Kaznacheev wrote:
> Lets test device list listeners as well. Maybe in a separate patch.

There's another CL such test could be based on:
https://codereview.chromium.org/291193007/

[Vladislav Kaznacheev, 2014-06-03 10:15:18]

lgtm

[vkuzkokov, 2014-06-03 10:34:16]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2014-06-03 10:34:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/305013013/100001

[vkuzkokov, 2014-06-03 14:43:56]

The CQ bit was unchecked by vkuzkokov@chromium.org

[vkuzkokov, 2014-06-03 14:54:55]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2014-06-03 14:55:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/305013013/120001

[commit-bot: I haz the power, 2014-06-03 18:40:42]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-03 20:44:04]

Change committed as 274611