Issue 305013009: Handle more types of gypis in gypi_to_gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305013009: Handle more types of gypis in gypi_to_gn. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Handle more types of gypis in gypi_to_gn. - This strips conditions inside a variables in addition to the toplevel conditions. - Removes percent signs from the ends of variable names. Both of these are required to import some of the Blink .gypis. Make net forward the crypto config. This appears to be necessary to use net's public API. R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274302

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -13 lines)			Patch
	M	build/gypi_to_gn.py	View		2 chunks	+14 lines, -13 lines	0 comments	Download
	M	net/BUILD.gn	View		1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

lgtm https://codereview.chromium.org/305013009/diff/20001/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/305013009/diff/20001/net/BUILD.gn#newcode103 net/BUILD.gn:103: ] Ah, didn't know about this ... nice.

6 years, 6 months ago (2014-06-02 18:56:53 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r274302.

Expand Messages | Collapse Messages