chrome/browser/devtools/devtools_protocol.cc - Issue 305013006: Fix memory leak in DevToolsProtocol::ParseCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_protocol.cc

Issue 305013006: Fix memory leak in DevToolsProtocol::ParseCommand (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_protocol.cc

diff --git a/chrome/browser/devtools/devtools_protocol.cc b/chrome/browser/devtools/devtools_protocol.cc

index ef7cb6ae63a950f11404acbc7175e81cd1143925..1823033a1742f5d042edfe80d4839e03dc9b14a3 100644

--- a/chrome/browser/devtools/devtools_protocol.cc

+++ b/chrome/browser/devtools/devtools_protocol.cc

@@ -129,7 +129,7 @@ DevToolsProtocol::Command* DevToolsProtocol::ParseCommand(

base::DictionaryValue* params = NULL;

command_dict->GetDictionary(kParamsParam, &params);

- return new Command(id, method, params ? params->DeepCopy() : NULL);

+ return new Command(id, method, params);

}

// static

« no previous file with comments | « chrome/browser/devtools/devtools_protocol.h ('k') | no next file » | no next file with comments »