Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 305013005: Add woff2_dec target (Closed)

Created:
6 years, 6 months ago by bashi
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add woff2_dec target Preparation for removing woff2 from ots TEST=compiled woff2_dec target BUG=371267 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275279

Patch Set 1 #

Patch Set 2 : gn fix #

Patch Set 3 : Update brotli #

Patch Set 4 : Fix README.chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/brotli/BUILD.gn View 1 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/brotli/README.chromium View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/brotli/brotli.gyp View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bashi
Hi Bret, I got a build error on android_chromium_gn_compile_rel. It seems I overlooked something in ...
6 years, 6 months ago (2014-05-30 05:38:39 UTC) #1
brettw
vector.data() is a C++11 addition so I wouldn't expect it to work consistently across platforms ...
6 years, 6 months ago (2014-05-30 17:29:27 UTC) #2
bashi
On 2014/05/30 17:29:27, brettw wrote: > vector.data() is a C++11 addition so I wouldn't expect ...
6 years, 6 months ago (2014-06-03 23:56:56 UTC) #3
bashi
Adding ksakamoto for OWNERS review
6 years, 6 months ago (2014-06-03 23:57:28 UTC) #4
Kunihiko Sakamoto
lgtm
6 years, 6 months ago (2014-06-04 01:08:47 UTC) #5
bashi
I'm going to commit this, assuming that BUILD.gn is fine.
6 years, 6 months ago (2014-06-05 23:22:03 UTC) #6
bashi
The CQ bit was checked by bashi@chromium.org
6 years, 6 months ago (2014-06-05 23:22:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/305013005/60001
6 years, 6 months ago (2014-06-05 23:24:16 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 00:08:38 UTC) #9
Message was sent while issue was closed.
Change committed as 275279

Powered by Google App Engine
This is Rietveld 408576698