Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 3050019: Don't use hardcoded offsets for parsing. (Closed)

Created:
10 years, 5 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
vb
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Don't use hardcoded offsets for parsing. Forgot to propagate the use of area_offset= pattern for ouput parsing to the unpacking script. BUG=none TEST=Tested by running on a firmware image with flashmap enabled. Correctly parsed the section offsets and sizes and output them to files.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M scripts/image_signing/unpack_firmwarefd.sh View 1 chunk +21 lines, -8 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
gauravsh
10 years, 5 months ago (2010-07-27 18:04:24 UTC) #1
vb
LGTM After testing and describing the test in the CL description. http://codereview.chromium.org/3050019/diff/1/2 File scripts/image_signing/unpack_firmwarefd.sh (right): ...
10 years, 5 months ago (2010-07-27 18:18:50 UTC) #2
gauravsh
10 years, 5 months ago (2010-07-27 18:45:26 UTC) #3
Fixed the issue description with testing description and submitted.

http://codereview.chromium.org/3050019/diff/1/2
File scripts/image_signing/unpack_firmwarefd.sh (right):

http://codereview.chromium.org/3050019/diff/1/2#newcode32
scripts/image_signing/unpack_firmwarefd.sh:32: let gbb_offset="$offset"
On 2010/07/27 18:18:50, vb wrote:
> is 'let' needed here and in line 34?

Yes, to force hex->decimal conversion since dd doesn't like 0x.. style hex
number literals.

Powered by Google App Engine
This is Rietveld 408576698