[Android][Mirror] UMA stats for Account management screen.

[Android][Mirror] UMA stats for Account management screen.

BUG=376860
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274519

[aruslan, 2014-06-03 00:38:53]

David -- could you PTAL, thanks!

dtrainor -- android/ and java OWNER.
noms@ -- browser/profiles/ OWNER.
rogerta@ -- browser/signin/ OWNER.

[aruslan, 2014-06-03 00:41:31]

isherman@ -- tools/metrics/histograms OWNER.

[noms (inactive), 2014-06-03 00:52:09]

profiles lgtm % tiny nits

https://codereview.chromium.org/304983005/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_metrics.h (right):

https://codereview.chromium.org/304983005/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_metrics.h:138: // User toggled Chrome signout,
and clicks Signout.
super tiny nit: the other comments use "clicked", in the past, while these two
use "clicks". should all be "clicked", maybe? :)

[David Trainor- moved to gerrit, 2014-06-03 00:54:28]

lgtm

https://chromiumcodereview.appspot.com/304983005/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementScreenHelper.java
(right):

https://chromiumcodereview.appspot.com/304983005/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementScreenHelper.java:31:
int gaiaServiceType);
line above?

https://chromiumcodereview.appspot.com/304983005/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementScreenHelper.java:46:
int gaiaServiceType) {
line above?

https://chromiumcodereview.appspot.com/304983005/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementScreenHelper.java:54:
* Enum for tracking user interactions with the account management menu
Add todo to generate from native?

https://chromiumcodereview.appspot.com/304983005/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementScreenHelper.java:59:
public static final int ACCOUNT_MANAGEMENT_MENU_VIEW = 0;
should these be up top?

[Roger Tawa OOO till Jul 10th, 2014-06-03 01:00:33]

lgtm

[aruslan, 2014-06-03 01:05:23]

Thanks a ton, David, Monica, Roger!

https://codereview.chromium.org/304983005/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementScreenHelper.java
(right):

https://codereview.chromium.org/304983005/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementScreenHelper.java:31:
int gaiaServiceType);
On 2014/06/03 00:54:28, David Trainor wrote:
> line above?

Done.

https://codereview.chromium.org/304983005/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementScreenHelper.java:46:
int gaiaServiceType) {
On 2014/06/03 00:54:28, David Trainor wrote:
> line above?

Done.

https://codereview.chromium.org/304983005/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementScreenHelper.java:54:
* Enum for tracking user interactions with the account management menu
On 2014/06/03 00:54:28, David Trainor wrote:
> Add todo to generate from native?

Done.

https://codereview.chromium.org/304983005/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementScreenHelper.java:59:
public static final int ACCOUNT_MANAGEMENT_MENU_VIEW = 0;
On 2014/06/03 00:54:28, David Trainor wrote:
> should these be up top?

Done.

https://codereview.chromium.org/304983005/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_metrics.h (right):

https://codereview.chromium.org/304983005/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_metrics.h:138: // User toggled Chrome signout,
and clicks Signout.
On 2014/06/03 00:52:10, Monica Dinculescu wrote:
> super tiny nit: the other comments use "clicked", in the past, while these two
> use "clicks". should all be "clicked", maybe? :)

Done, thanks :)

[Ilya Sherman, 2014-06-03 01:09:53]

https://codereview.chromium.org/304983005/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/304983005/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:21294: + 
<owner>mlerman@chromium.org</owner>
Hmm, how come you've listed Mike as owner, but not yourself?

https://codereview.chromium.org/304983005/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:21298: +    content area or some other
source, is noted in the histogram suffix.
The second sentence has a few typos.  However, you can probably just remove it
entirely -- I believe the labels from the histogram_suffixes groups are appended
to the histogram descriptions.

https://codereview.chromium.org/304983005/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:41191: +    User arrived to the Account
management screen.
nit: "arrived to" -> "arrived at"

[aruslan, 2014-06-03 01:17:44]

Thanks, Ilya, PTAL.

https://codereview.chromium.org/304983005/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/304983005/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:21294: + 
<owner>mlerman@chromium.org</owner>
On 2014/06/03 01:09:53, Ilya Sherman wrote:
> Hmm, how come you've listed Mike as owner, but not yourself?

Done.

https://codereview.chromium.org/304983005/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:21298: +    content area or some other
source, is noted in the histogram suffix.
On 2014/06/03 01:09:53, Ilya Sherman wrote:
> The second sentence has a few typos.  However, you can probably just remove it
> entirely -- I believe the labels from the histogram_suffixes groups are
appended
> to the histogram descriptions.

Done.

https://codereview.chromium.org/304983005/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:41191: +    User arrived to the Account
management screen.
On 2014/06/03 01:09:53, Ilya Sherman wrote:
> nit: "arrived to" -> "arrived at"

Done.

[Ilya Sherman, 2014-06-03 01:25:21]

histograms LGTM, thanks.

[aruslan, 2014-06-03 01:42:13]

Thanks, everyone!

[aruslan, 2014-06-03 01:55:41]

The CQ bit was checked by aruslan@chromium.org

[commit-bot: I haz the power, 2014-06-03 01:56:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aruslan@chromium.org/304983005/50001

[commit-bot: I haz the power, 2014-06-03 05:13:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-06-03 07:28:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-03 07:28:00]

Try jobs failed on following builders:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[aruslan, 2014-06-03 13:25:52]

The CQ bit was checked by aruslan@chromium.org

[commit-bot: I haz the power, 2014-06-03 13:27:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aruslan@chromium.org/304983005/50001

[commit-bot: I haz the power, 2014-06-03 14:00:49]

Change committed as 274519