Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 304933002: Revert of Fall back to X11 system tray icons if libappindicator is not available (Closed)

Created:
6 years, 6 months ago by Mathieu
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Fall back to X11 system tray icons if libappindicator is not available (https://codereview.chromium.org/291893009/) Reason for revert: Suspected ASAN leak on the bots. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2617 Original issue's description: > Fall back to X11 system tray icons if libappindicator is not available. > > This CL also splits out the code wrt to handling the GTK menu for the app indicator icon out of app_indicator_icon.cc in order to share code with gtk2_status_icon.cc > > BUG=267195 > TEST=Manual, see steps below. > 1) Run chrome in a system which does not have libappindicator > 2) Generate HTML 5 notifications via https://developer.cdn.mozilla.net/media/uploads/demos/e/l/elfoxero/c17223c414d8ddafb7808972b5617d9e/html5-notifications_1400214081_demo_package/index.html > 3) Ensure that the bell icon shows up in the system tray and that clicking on the bell icon brings up the message center > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273337 TBR=erg@chromium.org,pkotwicz@chromium.org NOTREECHECKS=true NOTRY=true BUG=267195 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273485

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -365 lines) Patch
M chrome/browser/ui/libgtk2ui/app_indicator_icon.h View 4 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/app_indicator_icon.cc View 6 chunks +94 lines, -24 lines 0 comments Download
D chrome/browser/ui/libgtk2ui/app_indicator_icon_menu.h View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/ui/libgtk2ui/app_indicator_icon_menu.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/ui/libgtk2ui/gtk2_status_icon.h View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/ui/libgtk2ui/gtk2_status_icon.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/libgtk2ui.gyp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mathieu
Created Revert of Fall back to X11 system tray icons if libappindicator is not available
6 years, 6 months ago (2014-05-29 15:15:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/304933002/1
6 years, 6 months ago (2014-05-29 15:17:30 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 15:19:55 UTC) #3
Message was sent while issue was closed.
Change committed as 273485

Powered by Google App Engine
This is Rietveld 408576698