DescriptionRevert of Fall back to X11 system tray icons if libappindicator is not available (https://codereview.chromium.org/291893009/)
Reason for revert:
Suspected ASAN leak on the bots.
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2617
Original issue's description:
> Fall back to X11 system tray icons if libappindicator is not available.
>
> This CL also splits out the code wrt to handling the GTK menu for the app indicator icon out of app_indicator_icon.cc in order to share code with gtk2_status_icon.cc
>
> BUG=267195
> TEST=Manual, see steps below.
> 1) Run chrome in a system which does not have libappindicator
> 2) Generate HTML 5 notifications via https://developer.cdn.mozilla.net/media/uploads/demos/e/l/elfoxero/c17223c414d8ddafb7808972b5617d9e/html5-notifications_1400214081_demo_package/index.html
> 3) Ensure that the bell icon shows up in the system tray and that clicking on the bell icon brings up the message center
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273337
TBR=erg@chromium.org,pkotwicz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=267195
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273485
Patch Set 1 #
Created: 6 years, 6 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|