IDL compiler: EventHandler for setters

Source/bindings/scripts/unstable/v8_types.py

Index: Source/bindings/scripts/unstable/v8_types.py
diff --git a/Source/bindings/scripts/unstable/v8_types.py b/Source/bindings/scripts/unstable/v8_types.py
index 858f856ec3d98b3369d35729a922a19f249cfc81..d24567e98b6970f68b074dfc054f71431e7033ae 100644
--- a/Source/bindings/scripts/unstable/v8_types.py
+++ b/Source/bindings/scripts/unstable/v8_types.py
@@ -290,6 +290,7 @@ def skip_includes(idl_type):
             enum_type(idl_type))
 
 INCLUDES_FOR_TYPE = {
+    'EventHandler': set(['bindings/v8/V8AbstractEventListener.h']),
     'Promise': set(['ScriptPromise.h']),
     'SerializedScriptValue': set(['bindings/v8/SerializedScriptValue.h']),
 }
@@ -369,7 +370,6 @@ def v8_value_to_cpp_value(idl_type, extended_attributes, v8_value, includes, iso
     'V8{idl_type}::HasInstance({v8_value}, {isolate}, worldType({isolate})) ? '
     'V8{idl_type}::toNative(v8::Handle<v8::Object>::Cast({v8_value})) : 0')
         includes.update(includes_for_type(idl_type))
-        includes.add('V8%s.h' % idl_type)
 
     return cpp_expression_format.format(arguments=arguments, idl_type=idl_type, isolate=isolate, v8_value=v8_value)
 
@@ -461,13 +461,9 @@ def v8_conversion_type(idl_type, extended_attributes, includes):
             includes.update(includes_for_type(this_array_or_sequence_type))
         return 'array'
 
-    if idl_type == 'EventHandler':
-        includes.add('bindings/v8/V8AbstractEventListener.h')
-        return 'EventHandler'
-
     includes.update(includes_for_type(idl_type))
-    if idl_type == 'SerializedScriptValue':
-        return 'SerializedScriptValue'
+    if idl_type in ['EventHandler', 'SerializedScriptValue']:

[haraken, 2013/10/19 12:41:29]

I wonder why this isn't 'if idl_type in INCLUDES_FOR_TYPE'.

[Nils Barth (inactive), 2013/10/21 02:41:38]

That works; changed!
(With "always use includes_for_type" CL this won't change generated code.)

+        return idl_type
 
     # Pointer type
     includes.add('wtf/GetPtr.h')  # FIXME: Is this necessary?